Improving docs about test script creation #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedroMMM
suggested changes
Mar 17, 2020
There was a problem hiding this comment.
@shan100github thank you for the documentation PR 🎉
I have a few proposed changes to not reference the Goss files like scripts and a few wording changes.
Updated suggestion Co-Authored-By: Pedro Medeiros <13643195+pedroMMM@users.noreply.github.com>
Updated suggestion Co-Authored-By: Pedro Medeiros <13643195+pedroMMM@users.noreply.github.com>
Updated suggestion Co-Authored-By: Pedro Medeiros <13643195+pedroMMM@users.noreply.github.com>
|
Thanks for your feedback @pedroMMM |
|
@aelsabbahy @pedroMMM |
pedroMMM
suggested changes
Mar 18, 2020
There was a problem hiding this comment.
@shan100github thank you for the quick turn around but I am sorry, I missed something.
While giving the PR one last quick look I realized that I missed one instance of referring to the YAML file as a script.
@aelsabbahy can merge after that last fix.
Updated suggestion. Co-Authored-By: Pedro Medeiros <13643195+pedroMMM@users.noreply.github.com>
pedroMMM
approved these changes
Mar 18, 2020
|
thanks for approval @pedroMMM even I overlooked it :( |
BenjaminHerbert
pushed a commit
to BenjaminHerbert/goss
that referenced
this pull request
May 28, 2020
* Adding in information about test script creation in docs * Update docs/manual.md Updated suggestion Co-Authored-By: Pedro Medeiros <13643195+pedroMMM@users.noreply.github.com> * Update docs/manual.md Updated suggestion Co-Authored-By: Pedro Medeiros <13643195+pedroMMM@users.noreply.github.com> * Update docs/manual.md Updated suggestion Co-Authored-By: Pedro Medeiros <13643195+pedroMMM@users.noreply.github.com> * Update docs/manual.md Updated suggestion. Co-Authored-By: Pedro Medeiros <13643195+pedroMMM@users.noreply.github.com> Co-authored-by: Pedro Medeiros <13643195+pedroMMM@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of change
Adding in details about "Goss test script creation" methods and manul edit scenario.
Currently, no specific section covering details about test script generation.