fix "dgoss edit" return code #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before dgoss edit returned a 1 return code if GOSS_VARS was unset but the command was valid. By refactoring the test of GOSS_VARS with the if clause, dgoss edit command returns the return code of get_docker_file function. Signed-off-by: Andrea Grillo <andrea.grillo96@live.com>
aelsabbahy
approved these changes
Jun 3, 2023
|
You're welcome! I'm glad to have contributed to this amazing project ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make test-all(UNIX) passes. CI will also test thisDescription of change
Before dgoss edit returned a 1 return code if GOSS_VARS was unset but the command was valid.
By refactoring the test of GOSS_VARS with the if clause, dgoss edit command returns the return code of get_docker_file function.