Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adapt tests for openssl crl/req exit code on verification failure #452

Closed
vladak opened this issue Mar 20, 2024 · 2 comments
Closed

adapt tests for openssl crl/req exit code on verification failure #452

vladak opened this issue Mar 20, 2024 · 2 comments
Assignees
@vt-alt

Comments

@vladak
Copy link

vladak commented Mar 20, 2024

In PR openssl/openssl#23773 I am about to change the exit code used by the openssl req and openssl crl commands on verification failure. This will likely be part of OpenSSL 3.3.x. Some of the gost-engine tests expect the exit code on verification failure to be 0. These have to be adapted to the new behavior.
@vt-alt vt-alt self-assigned this Mar 20, 2024
@vt-alt
Copy link
Member

vt-alt commented Mar 20, 2024

Thanks for the heads up. Will look at this on weekend.

@vt-alt vt-alt closed this as completed in 769e0f7 Mar 22, 2024
@vt-alt
Copy link
Member

vt-alt commented Mar 22, 2024 •
edited

I introduced the test suite change that should make tests pass with and without your PR.

ps. Amended the commit because I thought verify failure message is always on stderr but it wasn't.

vt-alt added a commit that referenced this issue Mar 22, 2024
@vt-alt
tcl_tests: ca.try: Ignore openssl crl exit status for 'corrupted CRL'…
456e71b 
… test

Older `openssl crl` exits with 0 in regard to verify no matter actual verify
status, newer `openssl crl` could exit with 1 on verify failure. Make the test
backward-compatible, comparing only stderr output.

Fixes: #452
Signed-off-by: Vitaly Chikunov <vt@altlinux.org>
vt-alt added a commit that referenced this issue Mar 22, 2024
@vt-alt
tcl_tests: ca.try: Ignore openssl crl exit status for 'corrupted CRL'…
ede3886 
… test

Older `openssl crl` exits with 0 in regard to verify no matter actual verify
status, newer `openssl crl` could exit with 1 on verify failure. Make the test
backward-compatible comparing only an output.

Fixes: #452
Signed-off-by: Vitaly Chikunov <vt@altlinux.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vt-alt vt-alt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vladak @vt-alt