Tests for bridge methods #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gosu fails to generate bridge methods in certain cases. Created a test to reproduce the issue.
|
This is fixed in the Java8 branch with change e8deca4 from June 21 |
|
Yep, but this pull request is to add new tests for this bug. I think, it is still valuable to increase test coverage (unless you implemented tests for it, too). |
|
I think, I found another case. I'll open a separate pull request against java8 since original issue is fixed there. |
|
Ah, thanks Ivan, I'll merge that one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gosu fails to generate bridge methods in certain cases.
Created a test to reproduce the issue.
See missing-bridge-methods-fix for the fix I implemented. It is in the separate branch since I am not sure about the fix quality. It makes tests to pass, though.