Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font refactoring, font fallbacks #448

Merged
merged 9 commits into from
Aug 29, 2018
Merged

Font refactoring, font fallbacks #448

merged 9 commits into from
Aug 29, 2018

Conversation

jlnr
Copy link
Member

@jlnr jlnr commented May 4, 2018

This branch is the continuation of #429:

  • Refactor new text parsing code to use normalized UCS-4 instead of graphemes, since our TTF rendering code cannot handle complex graphemes anyway (bummer).
  • Refactor new TTF code to add font fallback logic, otherwise CJK text can't be rendered using Gosu.default_font_name :/
  • Fix markup (I think bold is broken right now?)
  • Fix dark pixels around text on translucent background
  • Fix missing text/weird offsets in text-markup-1.png
  • Fix dark spots where letters overlap
  • Fix tests (even the ones I broke on master) (I think I should do a separate, focused test PR – right now it's OK for me if the tests only work on macOS)

@jlnr jlnr mentioned this pull request May 4, 2018
10 tasks
@jlnr jlnr force-pushed the font-fallbacks branch 2 times, most recently from c1d5c01 to 7355ed7 Compare July 15, 2018 08:53
@jlnr jlnr mentioned this pull request Jul 15, 2018
8 tasks
@jlnr jlnr merged commit 90441fc into master Aug 29, 2018
@jlnr jlnr deleted the font-fallbacks branch August 29, 2018 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant