Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize CMake setup #535

Merged
merged 12 commits into from May 25, 2020
Merged

Modernize CMake setup #535

merged 12 commits into from May 25, 2020

Conversation

jlnr
Copy link
Member

@jlnr jlnr commented May 24, 2020

Being able to load Gosu in CLion (through CMake) would be great for Linux development, also to get CLion's excellent refactoring & inspection support.

@jlnr jlnr changed the title Modernize CMake setup CLion compatibility May 24, 2020
@jlnr jlnr force-pushed the cmake-setup branch 5 times, most recently from 5171c60 to e663c5d Compare May 24, 2020 15:20
@jlnr jlnr changed the title CLion compatibility Modernize CMake setup May 25, 2020
@jlnr
Copy link
Member Author

jlnr commented May 25, 2020

@oli-obk I'm not sure if you are still following this project. If you are, please do let me know if I'm breaking more than necessary.
My current plan is to kick Win32 support out of the CMake files, then hopefully replace all audio dependencies with a statically included SDL_sound, and finally to bring Win32 support back when SDL2 is the only dependency. I also hope that a lot of the Win32 special-casing is not necessary anymore with "modern" CMake.

Edit: I also just realized that the previous CMake setup is from 2012!! Time flies.

@jlnr jlnr merged commit 706d81a into master May 25, 2020
@jlnr jlnr deleted the cmake-setup branch May 25, 2020 09:49
@oli-obk
Copy link
Contributor

oli-obk commented May 26, 2020

I was still using gosu up to last year, but not via cmake. I stopped teaching C++ last year, thus also stopped doing the gosu course. But the course still happens every year, just with someone else doing the teaching.

From my perspective, feel free to brick anything. The course has its own setup via MSVC and won't really be affected.

@jlnr
Copy link
Member Author

jlnr commented Jun 6, 2020

@oli-obk Great to hear that there's still a course going on 😎 I'll try to keep things sane while refactoring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants