Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): add methods for updating and resetting password #682

Merged
merged 6 commits into from Jan 29, 2022

Conversation

tdakkota
Copy link
Member

Updates #615.

@tdakkota tdakkota force-pushed the feat/add-more-auth-methods branch from 252353e to bb3f7ee Compare Jan 29, 2022
@codecov
Copy link

codecov bot commented Jan 29, 2022

Codecov Report

Merging #682 (26c5138) into main (30f12fb) will increase coverage by 0.14%.
The diff coverage is 82.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #682      +/-   ##
==========================================
+ Coverage   69.24%   69.39%   +0.14%     
==========================================
  Files         426      430       +4     
  Lines       20413    20526     +113     
==========================================
+ Hits        14135    14243     +108     
+ Misses       5373     5372       -1     
- Partials      905      911       +6     
Impacted Files Coverage Δ
telegram/auth/signup.go 73.33% <ø> (ø)
telegram/auth/user.go 59.25% <50.00%> (+4.60%) ⬆️
internal/crypto/srp/new_hash.go 75.00% <75.00%> (ø)
telegram/auth/password.go 77.27% <77.27%> (ø)
internal/crypto/srp/hash.go 87.83% <87.83%> (ø)
internal/crypto/srp/pad.go 100.00% <100.00%> (ø)
internal/crypto/srp/srp.go 100.00% <100.00%> (+12.76%) ⬆️
internal/testutil/rand.go 72.72% <100.00%> (+2.72%) ⬆️
telegram/auth/flow.go 76.08% <100.00%> (+2.75%) ⬆️
telegram/updates/gap_buffer.go 71.42% <0.00%> (-10.72%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30f12fb...26c5138. Read the comment docs.

@tdakkota tdakkota marked this pull request as ready for review Jan 29, 2022
@tdakkota tdakkota force-pushed the feat/add-more-auth-methods branch from 51ec4c7 to 26c5138 Compare Jan 29, 2022
@ernado ernado merged commit b084b6b into gotd:main Jan 29, 2022
19 checks passed
@tdakkota tdakkota deleted the feat/add-more-auth-methods branch Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants