Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging #5

Merged
merged 4 commits into from May 4, 2018
Merged

Logging #5

merged 4 commits into from May 4, 2018

Conversation

gulien
Copy link
Collaborator

@gulien gulien commented May 4, 2018

Adding debug messages which helps to understand whats going on!

Checklist

  • Have you followed the guidelines in our CONTRIBUTING guide?
  • Have you lint your code locally prior to submission (orbit run fmt)?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally (orbit run ci)?
  • I have squashed any insignificant commits
  • This change has comments for package types, values, functions, and non-obvious lines of code

@gulien gulien added the enhancement New feature or request label May 4, 2018
@gulien gulien added this to the 2.0.0 milestone May 4, 2018
@gulien gulien mentioned this pull request May 4, 2018
4 tasks
@codecov
Copy link

codecov bot commented May 4, 2018

Codecov Report

Merging #5 into master will decrease coverage by 0.87%.
The diff coverage is 81.81%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5      +/-   ##
=======================================
- Coverage   90.87%   90%   -0.88%     
=======================================
  Files           8     8              
  Lines         307   310       +3     
=======================================
  Hits          279   279              
- Misses         16    18       +2     
- Partials       12    13       +1
Impacted Files Coverage Δ
app/context/context.go 100% <ø> (ø) ⬆️
app/converter/file/file.go 76.47% <100%> (-1.31%) ⬇️
app/converter/process/process.go 79.16% <100%> (-1.23%) ⬇️
app/http/http.go 100% <100%> (ø) ⬆️
app/converter/converter.go 85.1% <50%> (-5.37%) ⬇️
app/handlers.go 87.95% <80%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 810d35f...2f2dec6. Read the comment docs.

@gulien gulien merged commit 2871fb1 into master May 4, 2018
@gulien gulien deleted the logging branch May 4, 2018 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant