Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slighty improvement of logging #6

Merged
merged 1 commit into from May 16, 2018
Merged

slighty improvement of logging #6

merged 1 commit into from May 16, 2018

Conversation

gulien
Copy link
Collaborator

@gulien gulien commented May 16, 2018

Improving logging (a little)

Checklist

  • Have you followed the guidelines in our CONTRIBUTING guide?
  • Have you lint your code locally prior to submission (orbit run fmt)?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally (orbit run ci)?
  • I have squashed any insignificant commits
  • This change has comments for package types, values, functions, and non-obvious lines of code

@gulien gulien added this to the 2.0.0 milestone May 16, 2018
@gulien gulien mentioned this pull request May 16, 2018
4 tasks
@codecov
Copy link

codecov bot commented May 16, 2018

Codecov Report

Merging #6 into master will increase coverage by 0.27%.
The diff coverage is 95.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
+ Coverage      90%   90.27%   +0.27%     
==========================================
  Files           8        8              
  Lines         310      329      +19     
==========================================
+ Hits          279      297      +18     
  Misses         18       18              
- Partials       13       14       +1
Impacted Files Coverage Δ
app/context/context.go 100% <100%> (ø) ⬆️
app/handlers.go 87.77% <88.88%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2871fb1...2fd7a3b. Read the comment docs.

@gulien gulien merged commit faec55d into master May 16, 2018
@gulien gulien deleted the request_id branch May 16, 2018 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant