-
-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added TLS/SSL support #888
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments otherwise 👍 thanks a lot!
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #888 +/- ##
==========================================
+ Coverage 91.89% 91.91% +0.02%
==========================================
Files 46 46
Lines 4009 4021 +12
==========================================
+ Hits 3684 3696 +12
Misses 230 230
Partials 95 95 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Julien Neuhart <neuhart.julien@gmail.com>
Co-authored-by: Julien Neuhart <neuhart.julien@gmail.com>
2be23fa
to
7dc83e6
Compare
7dc83e6
to
6a7bda8
Compare
@gulien should I try to get better test coverage by making a scenario where it throws an error in |
Okay I'm not sure how to do that 😅 Tried passing in invalid TLS files but the error is thrown with |
Co-authored-by: Julien Neuhart <neuhart.julien@gmail.com>
6a7bda8
to
e5e8434
Compare
@jonasgeiler My bad; actually, I just want most of the lines you've added to be covered. But on scenarios like this one it's simply not feasible 😄 |
Thanks a lot for your time @jonasgeiler! The release |
@gulien Awesome! Thanks! 🎉 |
Closes #243
Description
This PR adds support for passing TLS/SSL certificates/keys to the API server, which makes it possible to use encrypted HTTPS connections for communicating with Gotenberg.
I basically added two new flags,
--api-tls-cert-file
and--api-tls-key-file
, which can be set to the location of the TLS/SSL files. Then, when starting the API server, it will use theStartTLS
method instead of theStartH2CServer
method to start a server with HTTPS support and everything should be the same from there on out.TODO
Open for review!