Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add libre office image options #898

Merged
merged 3 commits into from
Jun 13, 2024
Merged

add libre office image options #898

merged 3 commits into from
Jun 13, 2024

Conversation

garethjudson
Copy link
Contributor

Allow the specifying of losslessImageCompression and reduceImageResolution form data items when calling the convert api endpoint (libreoffice)

These correspond to the ReduceImageResolution and UseLosslessCompression command line arguments to libre office

@gulien gulien added enhancement New feature or request libreoffice labels Jun 12, 2024
@gulien
Copy link
Collaborator

gulien commented Jun 12, 2024

Thank you very much for this PR @garethjudson!

pkg/modules/libreoffice/api/api.go Outdated Show resolved Hide resolved
pkg/modules/libreoffice/api/libreoffice.go Outdated Show resolved Hide resolved
pkg/modules/libreoffice/api/libreoffice.go Show resolved Hide resolved
pkg/modules/libreoffice/api/libreoffice_test.go Outdated Show resolved Hide resolved
pkg/modules/libreoffice/routes.go Outdated Show resolved Hide resolved
pkg/modules/libreoffice/routes.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.99%. Comparing base (ed67d85) to head (5cd67b4).
Report is 2 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #898      +/-   ##
==========================================
+ Coverage   91.91%   91.99%   +0.07%     
==========================================
  Files          46       46              
  Lines        4021     4046      +25     
==========================================
+ Hits         3696     3722      +26     
  Misses        230      230              
+ Partials       95       94       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gulien gulien merged commit 669a35a into gotenberg:main Jun 13, 2024
3 checks passed
@gulien
Copy link
Collaborator

gulien commented Jun 13, 2024

Thanks again @garethjudson!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request libreoffice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants