Merge pull request #146 from dnephin/remove-type-assert-for-pre-go1.12

Move ExitError type check to test file.
gotestyourself · Sep 1, 2020 · 4bafc65 · 4bafc65
2 parents 7a46c48 + 78884b8
commit 4bafc65
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/main.go b/main.go
@@ -390,5 +390,3 @@ func exitCodeWithDefault(err error) int {
 type exitCoder interface {
 	ExitCode() int
 }
-
-var _ exitCoder = &exec.ExitError{}
diff --git a/main_test.go b/main_test.go
@@ -3,6 +3,7 @@ package main
 import (
 	"bytes"
 	"os"
+	"os/exec"
 	"strings"
 	"testing"
 
@@ -356,3 +357,7 @@ func TestRun_RerunFails_BuildErrorPreventsRerun(t *testing.T) {
 	err := run(opts)
 	assert.ErrorContains(t, err, "rerun aborted because previous run had errors", out.String())
 }
+
+// type checking of os/exec.ExitError is done in a test file so that users
+// installing from source can continue to use versions prior to go1.12.
+var _ exitCoder = &exec.ExitError{}