Fix cve-2020-29652 #204
Merged
Fix cve-2020-29652 #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golang.org/x/crypto | CVE-2020-29652 | HIGH | v0.0.0-20200622213623-75b288015ac9
After fixing the lint error I ran 'go mod tidy', and it removed the dependency. Very nice.
dnephin
approved these changes
Jul 8, 2021
There was a problem hiding this comment.
Thank you for the PR!
I believe gotestsum never used the code identified in that CVE, but I understand the desire to remove the alert from any scans.
Thankfully it looks like someone did some work to move the one function that required x/crypto into x/term, and the linter told us where to find it. After running go mod tidy the x/crypto dependency is gone.
I pushed an additional commit with that change.
|
Thanks for patching that up and merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
golang.org/x/crypto | CVE-2020-29652 | HIGH | v0.0.0-20200622213623-75b288015ac9