fix: remove deprecated linters from golanci-lint #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yoan Blanc <yblanc@edgelab.ch>
dnephin
force-pushed
the
fix/golangci-lint
branch
from
7d2984f
to
2a49979
Compare
dnephin
approved these changes
Dec 18, 2021
There was a problem hiding this comment.
Thank you!
I made one change, which was to re-add interfacer. I understand it is archived, but I still find it to be useful, especially on a small project like this one. Sure sometimes it will give unhelpful suggestions, but I've found that to be rare. I can see it being more of a problem on large projects with many interfaces, but even then I think many of its suggestions are helpful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
golangci-lint passes like before.