Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(fmt): run cargo fmt to fix pull request CI #401

Merged
merged 1 commit into from Feb 19, 2020

Conversation

@secretfader
Copy link
Contributor

secretfader commented Feb 10, 2020

Here's an example of a PR that would've passed, but failed only on the formatting stage. Merging this PR (and rebasing the broken ones) may make code triage easier.

@secretfader secretfader changed the title chore(fmt): run cargo fmt to fix CI chore(fmt): run cargo fmt to fix pull request CI Feb 10, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 10, 2020

Codecov Report

Merging #401 into master will decrease coverage by <.01%.
The diff coverage is 89.47%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #401      +/-   ##
=========================================
- Coverage   79.51%   79.5%   -0.01%     
=========================================
  Files         105     105              
  Lines        4964    4963       -1     
=========================================
- Hits         3947    3946       -1     
  Misses       1017    1017
Impacted Files Coverage Δ
gotham/src/handler/assets/mod.rs 89.05% <89.47%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa64e50...c90e50a. Read the comment docs.

@colinbankier colinbankier merged commit d5d9fdf into gotham-rs:master Feb 19, 2020
3 checks passed
3 checks passed
codecov/patch 89.47% of diff hit (target 79.51%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +9.96% compared to aa64e50
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.