Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename JWTMiddleware to JwtMiddleware #537

Merged
merged 3 commits into from Jul 12, 2021

Conversation

msrd0
Copy link
Member

@msrd0 msrd0 commented Apr 13, 2021

This brings our API in line with the Rust API Guidelines. Follow-Up for #534

The old name is now a type alias that I marked deprecated as of 0.6.1. We should then probably publish 0.6.1 straight away so that people using the middleware get the deprecation warning and have time to update their code before the next breaking release.

@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@16a893f). Click here to learn what that means.
The diff coverage is 83.82%.

❗ Current head e311902 differs from pull request most recent head 9316cef. Consider uploading reports for the commit 9316cef to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##             master     #537   +/-   ##
=========================================
  Coverage          ?   85.00%           
=========================================
  Files             ?      110           
  Lines             ?     5608           
  Branches          ?        0           
=========================================
  Hits              ?     4767           
  Misses            ?      841           
  Partials          ?        0           
Impacted Files Coverage Δ
gotham/src/extractor/path.rs 66.66% <0.00%> (ø)
gotham/src/extractor/query_string.rs 66.66% <0.00%> (ø)
gotham/src/helpers/http/mod.rs 83.87% <ø> (ø)
gotham/src/helpers/timing.rs 0.00% <0.00%> (ø)
gotham/src/middleware/logger/mod.rs 0.00% <0.00%> (ø)
gotham/src/middleware/security/mod.rs 0.00% <0.00%> (ø)
gotham/src/middleware/timer/mod.rs 0.00% <0.00%> (ø)
gotham/src/pipeline/set.rs 100.00% <ø> (ø)
gotham/src/pipeline/single.rs 100.00% <ø> (ø)
gotham/src/router/builder/modify.rs 40.00% <ø> (ø)
... and 99 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16a893f...9316cef. Read the comment docs.

@msrd0 msrd0 added this to the 0.6.1 milestone May 25, 2021
@msrd0 msrd0 merged commit 76db23e into gotham-rs:master Jul 12, 2021
@msrd0 msrd0 deleted the rename-jwt-middleware branch July 12, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant