Remove TestServer::client_with_address #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method wasn't working as expected / documented for a while now and has been deprecated in gotham-rs#522 Since nobody ever created an issue about this, I assume this method is completely unused and therefore I believe it should be removed.
Codecov Report
@@ Coverage Diff @@
## master #555 +/- ##
==========================================
+ Coverage 85.02% 85.08% +0.05%
==========================================
Files 111 111
Lines 5748 5744 -4
==========================================
Hits 4887 4887
+ Misses 861 857 -4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method wasn't working as expected / documented for a while
now and has been deprecated in #552
Since nobody ever created an issue about this, I assume this method
is completely unused and therefore I believe it should be removed.