Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change error returned from start functions to custom enum #571

Merged
merged 3 commits into from
Oct 20, 2021

Conversation

msrd0
Copy link
Member

@msrd0 msrd0 commented Oct 13, 2021

This helps future-proofing the API. Thanks @FSMaxB for suggesting this in #568

This helps future-proofing the API. Thanks @FSMaxB for
suggesting this in gotham-rs#568
@codecov
Copy link

codecov bot commented Oct 13, 2021

Codecov Report

Merging #571 (ed3f94c) into master (d4f3780) will decrease coverage by 0.06%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #571      +/-   ##
==========================================
- Coverage   85.26%   85.19%   -0.07%     
==========================================
  Files         111      111              
  Lines        5768     5768              
==========================================
- Hits         4918     4914       -4     
- Misses        850      854       +4     
Impacted Files Coverage Δ
gotham/src/lib.rs 88.00% <ø> (ø)
gotham/src/tls/mod.rs 17.64% <0.00%> (ø)
gotham/src/plain/mod.rs 86.66% <100.00%> (ø)
gotham/src/middleware/session/backend/memory.rs 87.00% <0.00%> (-4.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4f3780...ed3f94c. Read the comment docs.

@msrd0 msrd0 added this to the 0.7 milestone Oct 13, 2021
@msrd0 msrd0 merged commit ecc604d into gotham-rs:master Oct 20, 2021
@msrd0 msrd0 deleted the change-io-error-to-custom-error branch October 20, 2021 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant