Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix session discard future not being Send #581

Merged
merged 2 commits into from
Nov 18, 2021

Conversation

msrd0
Copy link
Member

@msrd0 msrd0 commented Nov 18, 2021

Fixes #580

@codecov
Copy link

codecov bot commented Nov 18, 2021

Codecov Report

Merging #581 (c64e350) into main (7251955) will increase coverage by 0.33%.
The diff coverage is 95.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #581      +/-   ##
==========================================
+ Coverage   85.95%   86.28%   +0.33%     
==========================================
  Files         112      112              
  Lines        5781     5804      +23     
==========================================
+ Hits         4969     5008      +39     
+ Misses        812      796      -16     
Impacted Files Coverage Δ
gotham/src/middleware/session/mod.rs 81.76% <95.65%> (+4.63%) ⬆️
gotham/src/middleware/session/backend/memory.rs 96.93% <0.00%> (+6.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7251955...c64e350. Read the comment docs.

@msrd0 msrd0 merged commit 878e7b5 into gotham-rs:main Nov 18, 2021
@msrd0 msrd0 deleted the fix-session-future-not-send branch November 18, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Send in SessionData::discard's Future
1 participant