Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimal versions of anyhow, thiserror and serde #623

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

msrd0
Copy link
Member

@msrd0 msrd0 commented Sep 12, 2023

We actually require anyhow 1.0.5 and upwards to allow anyhow::Error to be used with hyper, and thiserror 1.0.2 to use the #[from] attribute. I also bumped serde to the oldest version after switching back to from-source compilation.

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #623 (03f279c) into main (3d11152) will not change coverage.
The diff coverage is n/a.

❗ Current head 03f279c differs from pull request most recent head 3c70bf9. Consider uploading reports for the commit 3c70bf9 to get more accurate results

@@           Coverage Diff           @@
##             main     #623   +/-   ##
=======================================
  Coverage   78.34%   78.34%           
=======================================
  Files          72       72           
  Lines        2050     2050           
=======================================
  Hits         1606     1606           
  Misses        444      444           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@msrd0
Copy link
Member Author

msrd0 commented Sep 12, 2023

For some reason, when using -Z minimal-versions the diesel example's test fails. But at least everything compiles, so this is still an improvement

@msrd0 msrd0 merged commit 5a92811 into gotham-rs:main Sep 12, 2023
9 checks passed
@msrd0 msrd0 deleted the bump-minimal-versions branch September 12, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant