assets: add range request support for FileHandler #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds range request support for FileHandler. This is a critical feature for handling large files, or any application that will require range request support, e.g. video or audio streaming. This implementation currentyl only supports ranges that result in a single response, i.e. multiple ranges are not supported. This implementation will return an error if a range is open from both ends, or if the range beginning is larger than the end. Signed-off-by: Janne Pelkonen <jpelkonen@ideanovatech.com>
msrd0
requested changes
Oct 12, 2023
…am-rs#628 Specifically: - Use pattern match instead of unwrap - Simplify resolve_range by reducing nesting - Use doc comments for functions - Use method format for seek Signed-off-by: Janne Pelkonen <jpelkonen@ideanovatech.com>
|
@msrd0 I appreciate your timely feedback and have addressed the issues raised in my latest commit. Thanks! |
Codecov Report
@@ Coverage Diff @@
## main #628 +/- ##
==========================================
+ Coverage 78.33% 78.73% +0.40%
==========================================
Files 72 72
Lines 2049 2088 +39
==========================================
+ Hits 1605 1644 +39
Misses 444 444
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…otham-rs#628 Use method format for seek Signed-off-by: Janne Pelkonen <jpelkonen@ideanovatech.com>
msrd0
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds range request support for FileHandler. This is a critical feature for handling large files, or any application that will require range request support, e.g. video or audio streaming.
This implementation currentyl only supports ranges that result in a single response, i.e. multiple ranges are not supported.
This implementation will return an error if a range is open from both ends, or if the range beginning is larger than the end.