Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix feature = "cargo-clippy" deprecation #645

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Fix feature = "cargo-clippy" deprecation #645

merged 1 commit into from
Mar 5, 2024

Conversation

rex4539
Copy link
Contributor

@rex4539 rex4539 commented Feb 28, 2024

msrd0
msrd0 previously approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@msrd0 msrd0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@msrd0 msrd0 enabled auto-merge (squash) February 28, 2024 22:32
@msrd0
Copy link
Member

msrd0 commented Feb 28, 2024

Hm I guess older clippy versions don't recognize cfg(clippy) which makes sense. Do we need the cfg_attr(clippy) anyways? The blog post seems to read like they could just be removed these days

@msrd0 msrd0 disabled auto-merge February 28, 2024 22:35
@codecov Codecov
Copy link

codecov bot commented Feb 28, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.68%. Comparing base (2b2aed2) to head (4ddc13c).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #645      +/-   ##
==========================================
+ Coverage   78.49%   78.68%   +0.19%     
==========================================
  Files          72       72              
  Lines        2088     2088              
==========================================
+ Hits         1639     1643       +4     
+ Misses        449      445       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rex4539 rex4539 requested a review from msrd0 March 4, 2024 13:37
@rex4539
Copy link
Contributor Author

rex4539 commented Mar 4, 2024

Applied the correct fix.

msrd0
msrd0 approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@msrd0 msrd0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@msrd0 msrd0 merged commit 6a2b527 into gotham-rs:main Mar 5, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msrd0 msrd0 msrd0 approved these changes

Assignees
No one assigned
Labels
non-breaking-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rex4539 @msrd0