Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Forwards Packages #95

Merged
merged 2 commits into from Nov 18, 2019
Merged

Upgrade Forwards Packages #95

merged 2 commits into from Nov 18, 2019

Conversation

Alonski
Copy link
Member

@Alonski Alonski commented Nov 18, 2019

No description provided.

patocallaghan
patocallaghan reviewed Nov 18, 2019
View reviewed changes
Copy link
Collaborator

@patocallaghan patocallaghan left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you're updating Prettier do we need to also run Prettier over the codebase? Formatting sometimes changes between the versions. If that's the case, it may be worth breaking out into a separate PR to reduce the noise.

@Alonski
Copy link
Member Author

Alonski commented Nov 18, 2019

As you're updating Prettier do we need to also run Prettier over the codebase? Formatting sometimes changes between the versions. If that's the case, it may be worth breaking out into a separate PR to reduce the noise.

I ran yarn lint:fix and things didn't change :)

@GCheung55
Copy link
Collaborator

LGTM

@GCheung55 GCheung55 merged commit f4e9431 into master Nov 18, 2019
@Alonski Alonski deleted the alon/upgrade-forwards-packages branch November 20, 2019 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patocallaghan patocallaghan patocallaghan approved these changes

@jonnii jonnii Awaiting requested review from jonnii

@GCheung55 GCheung55 Awaiting requested review from GCheung55

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Alonski @GCheung55 @patocallaghan