Make remaining public methods synchronized.

gotify · Feb 18, 2020 · 10b6741 · 10b6741
1 parent 48c2806
commit 10b6741
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/app/src/main/java/com/github/gotify/messages/provider/MessageFacade.java b/app/src/main/java/com/github/gotify/messages/provider/MessageFacade.java
@@ -18,17 +18,17 @@ public MessageFacade(MessageApi api, ApplicationHolder applicationHolder) {
         this.state = new MessageStateHolder();
     }
 
-    public List<MessageWithImage> get(Integer appId) {
+    public synchronized List<MessageWithImage> get(Integer appId) {
         return combiner.combine(state.state(appId).messages, applicationHolder.get());
     }
 
-    public void addMessages(List<Message> messages) {
+    public synchronized void addMessages(List<Message> messages) {
         for (Message message : messages) {
             state.newMessage(message);
         }
     }
 
-    public List<MessageWithImage> loadMore(Integer appId) {
+    public synchronized List<MessageWithImage> loadMore(Integer appId) {
         MessageState state = this.state.state(appId);
         if (state.hasNext || !state.loaded) {
             PagedMessages pagedMessages = requester.loadMore(state);
@@ -37,14 +37,14 @@ public List<MessageWithImage> loadMore(Integer appId) {
         return get(appId);
     }
 
-    public void loadMoreIfNotPresent(Integer appId) {
+    public synchronized void loadMoreIfNotPresent(Integer appId) {
         MessageState state = this.state.state(appId);
         if (!state.loaded) {
             loadMore(appId);
         }
     }
 
-    public void clear() {
+    public synchronized void clear() {
         this.state.clear();
     }
 
@@ -70,13 +70,13 @@ public synchronized MessageDeletion undoDeleteLocal() {
         return this.state.undoPendingDeletion();
     }
 
-    public boolean deleteAll(Integer appId) {
+    public synchronized boolean deleteAll(Integer appId) {
         boolean success = this.requester.deleteAll(appId);
         this.state.deleteAll(appId);
         return success;
     }
 
-    public boolean canLoadMore(Integer appId) {
+    public synchronized boolean canLoadMore(Integer appId) {
         return state.state(appId).hasNext;
     }
 }
diff --git a/app/src/main/java/com/github/gotify/messages/provider/MessageStateHolder.java b/app/src/main/java/com/github/gotify/messages/provider/MessageStateHolder.java
@@ -57,7 +57,7 @@ synchronized MessageState state(Integer appId) {
         return state;
     }
 
-    void deleteAll(Integer appId) {
+    synchronized void deleteAll(Integer appId) {
         clear();
         MessageState state = state(appId);
         state.loaded = true;
@@ -115,7 +115,7 @@ synchronized MessageDeletion purgePendingDeletion() {
         return result;
     }
 
-    boolean deletionPending() {
+    synchronized boolean deletionPending() {
         return pendingDeletion != null;
     }