Protection of intentURL attack using interactive dialog confirmation #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmattheis
reviewed
Oct 2, 2023
app/src/main/kotlin/com/github/gotify/messages/IntentUrlDialogActivity.kt
Outdated
Show resolved
Hide resolved
cyb3rko
force-pushed
the
intent-url-protection
branch
from
d611435
to
567fcb4
Compare
jmattheis
reviewed
Oct 3, 2023
cyb3rko
force-pushed
the
intent-url-protection
branch
from
fff5888
to
b85ce16
Compare
cyb3rko
force-pushed
the
intent-url-protection
branch
from
9fbb475
to
41bd73f
Compare
jmattheis
reviewed
Oct 5, 2023
app/src/main/kotlin/com/github/gotify/settings/SettingsActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/com/github/gotify/settings/SettingsActivity.kt
Outdated
Show resolved
Hide resolved
cyb3rko
force-pushed
the
intent-url-protection
branch
from
41bd73f
to
45b41b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed before here's the implementation using a dialog activity.
What's missing now is getting the permission. As it's rather optional to use this feature I wonder how we want to inform the user about the missing permission.
Same as with the other permissions right at the launch (InitializationActivity) or via the settings?
Closes #227