Update DefaultPage to be more general and add refresh button in web UI #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #233 +/- ##
=======================================
Coverage 90.87% 90.87%
=======================================
Files 43 43
Lines 1677 1677
=======================================
Hits 1524 1524
Misses 82 82
Partials 71 71Continue to review full report at Codecov.
|
added 2 commits
October 18, 2019 18:12
jmattheis
requested changes
Oct 18, 2019
ui/src/message/MessagesStore.ts
Outdated
| public refreshByApp = async (appId: number) => { | ||
| const state = this.stateOf(appId); | ||
| const result = await this.fetchMessages(appId, 0).then((resp) => resp.data); | ||
| state.messages.replace(result.messages); |
There was a problem hiding this comment.
I think we should refresh all messages because when refreshing only one application the "All Messages"-Tab will not get updated resulting in inconsistent state.
So we can use this.clearAll() to discard our state and this.loadMore() to get the most recent messages.
jmattheis
reviewed
Oct 18, 2019
ui/src/common/DefaultPage.tsx
Outdated
| buttonTitle?: string; | ||
| fButton?: VoidFunction; | ||
| buttonDisabled?: boolean; | ||
| rightControl?: object; |
There was a problem hiding this comment.
This can probably be a React.ReactNode
Co-Authored-By: Jannis Mattheis <contact@jmattheis.de>
jmattheis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated
DefaultPagecomponent to be more general following @jmattheis suggestions (see here).Now the component accepts a new argument
rightControluseful to specify a react node placed on the top right corner of the page content.Old specific purpose arguments
buttonTitle,fButton,buttonDisabled,hideButtonandbuttonIdwere removed.Using the improved
DefaultPage, we can easely solve the issue #171.