Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps & Add better websocket error logging #244

Merged
merged 7 commits into from Nov 28, 2019
Merged

Conversation

jmattheis
Copy link
Member

Fixes #243

@jmattheis jmattheis added this to the version+1 milestone Nov 28, 2019
@jmattheis jmattheis requested a review from a team as a code owner November 28, 2019 20:06
@codecov
Copy link

codecov bot commented Nov 28, 2019

Codecov Report

Merging #244 into master will decrease coverage by 0.07%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #244      +/-   ##
=========================================
- Coverage   90.87%   90.8%   -0.08%     
=========================================
  Files          43      43              
  Lines        1677    1685       +8     
=========================================
+ Hits         1524    1530       +6     
- Misses         82      83       +1     
- Partials       71      72       +1
Impacted Files Coverage Δ
error/handler.go 100% <100%> (ø) ⬆️
api/stream/client.go 96.61% <75%> (-3.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc74149...d764a8d. Read the comment docs.

@jmattheis jmattheis merged commit 0a7a5cd into master Nov 28, 2019
@jmattheis jmattheis deleted the update-deps branch November 28, 2019 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

ACMEv1 deprecation response from letsencrypt
1 participant