features : Applications sorted by name (Update Navigation.tsx) #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before : Applications were sorted by id (so by date of creation). Now : Applications are sorted by name
|
I think there should be an option. I like the fact that they are sorted by creation time. |
jmattheis
reviewed
Nov 14, 2023
| @@ -54,7 +54,7 @@ class Navigation extends Component< | |||
| public render() { | |||
| const {classes, loggedIn, appStore, navOpen, setNavOpen} = this.props; | |||
| const {showRequestNotification} = this.state; | |||
| const apps = appStore.getItems(); | |||
There was a problem hiding this comment.
This probably should be done in the back end, so that the ordering is consistent with the android app.
jmattheis
reviewed
Nov 14, 2023
| @@ -54,7 +54,7 @@ class Navigation extends Component< | |||
| public render() { | |||
There was a problem hiding this comment.
I'm not sure if I like the sorting by name. I'd rather have the applications order fully customizable via drag&drop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before : Applications were sorted by id (so by date of creation).
Now : Applications are sorted by name
this pull request is linked to #358