Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TypeScript definition #46

Merged
merged 4 commits into from
Mar 20, 2023
Merged

Add TypeScript definition #46

merged 4 commits into from
Mar 20, 2023

Conversation

kidonng
Copy link
Contributor

@kidonng kidonng commented Mar 10, 2023

Notes in comments

kidonng
kidonng commented Mar 10, 2023
View reviewed changes
README.md Show resolved Hide resolved
kidonng
kidonng commented Mar 10, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
kidonng
kidonng commented Mar 10, 2023
View reviewed changes
index.d.ts Outdated Show resolved Hide resolved
kidonng
kidonng commented Mar 10, 2023
View reviewed changes
index.d.ts Outdated Show resolved Hide resolved
@kidonng kidonng mentioned this pull request Mar 10, 2023
Merged
goto-bus-stop
goto-bus-stop reviewed Mar 10, 2023
View reviewed changes
Copy link
Owner

@goto-bus-stop goto-bus-stop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :D

package.json Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
kidonng and others added 2 commits March 20, 2023 22:22
@kidonng @goto-bus-stop
Update package.json
185da58 
Co-authored-by: Renée <renee@kooi.me>
@kidonng
Type the class
d18ea28
@kidonng
Copy link
Contributor Author

kidonng commented Mar 20, 2023

Almost forgot this 😅 @goto-bus-stop care to review again?

goto-bus-stop
goto-bus-stop approved these changes Mar 20, 2023
View reviewed changes
Copy link
Owner

@goto-bus-stop goto-bus-stop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! \ 😁 /

@goto-bus-stop goto-bus-stop merged commit 8cb72f6 into goto-bus-stop:default Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goto-bus-stop goto-bus-stop goto-bus-stop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kidonng @goto-bus-stop