Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved trigger system reading #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improved trigger system reading #46

wants to merge 1 commit into from

Conversation

yvan-burrie
Copy link

Improved the reading for the triggers system with version and data length used correctly. Although, I do not know where the triggers version is read and whether HD Edition still uses version 1.6. I did not test my code, so I hope it works!

Improved the reading for the triggers system with version and data length used correctly. Although, I do not know where the triggers version is read and whether HD Edition still uses version 1.6. I did not test my code, so I hope it works!
@goto-bus-stop
Copy link
Owner

Thanks! The scenery version identifier is definitely useful information.

There do seem to be a few issues. If you clone the repository, you can test your changes locally using composer run-script test. That'll try to run the code on a few dozen recorded game files from different AoE2 versions.

@yvan-burrie
Copy link
Author

Cool, I will have to try testing next time.

There's a lot more data that uses the scenery version, which needs to expanded on.

I believe the 64 bit float for the triggers version is used to detect the position for skipping huge amounts of unknown data? I will try to clarify some of those unknowns later, as HD Edition will maybe add things.

@yvan-burrie
Copy link
Author

I just realised I forgot to include the 16 bit integer known as "timelineAvailableId" which should be read between the timeline entries counter and the timeline entry structures, line 472.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants