Do not count class names and method names as undeclared #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for correctly detecting classes
This example right now would return
Aandmethodas undeclared identifiers.This PR fixes this and correctly detects them as binding identifiers/methods.
This issue came up with packd which uses browserify internally. For example:
https://bundle.run/@babel/plugin-proposal-class-properties@7.3.3
This failed bundling because @babel/generator defines a class called Buffer: https://unpkg.com/@babel/generator@7.3.3/lib/buffer.js
Hopefully with this fix it should work.
If this PR is okay and merged, it would be nice if you could create a new patch release, so I can forward this fix to packd.
Thanks in advance.