Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(search): support highlight feature in search response. #29

Merged
merged 3 commits into from
May 24, 2023
Merged

feat(search): support highlight feature in search response. #29

merged 3 commits into from
May 24, 2023

Conversation

anjali9791
Copy link

@anjali9791 anjali9791 commented May 23, 2023 •
edited by sudo-suhas
Loading

Closes #27

@coveralls
Copy link

coveralls commented May 23, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5065488619

  • 24 of 29 (82.76%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 85.848%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/store/elasticsearch/discovery_search_repository.go 18 23 78.26%
Totals Coverage Status
Change from base Build 5056071037: -0.02%
Covered Lines: 5235
Relevant Lines: 6098
💛 - Coveralls

sudo-suhas
sudo-suhas suggested changes May 24, 2023
View reviewed changes
core/asset/discovery.go Outdated Show resolved Hide resolved
internal/server/v1beta1/search.go Outdated Show resolved Hide resolved
internal/store/elasticsearch/discovery_search_repository.go Show resolved Hide resolved
internal/store/elasticsearch/discovery_search_repository.go Outdated Show resolved Hide resolved
@anjali9791 anjali9791 merged commit 4720071 into main May 24, 2023
3 checks passed
@anjali9791 anjali9791 deleted the highlight branch May 24, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sudo-suhas sudo-suhas sudo-suhas approved these changes

@StewartJingga StewartJingga Awaiting requested review from StewartJingga

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Highlight feature in search response
4 participants
@anjali9791 @coveralls @sudo-suhas @anjaliagg9791