Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(provider): fetch resources on provider update #16

Merged
merged 3 commits into from
Apr 6, 2023
Merged

feat(provider): fetch resources on provider update #16

merged 3 commits into from
Apr 6, 2023

Conversation

bsushmith
Copy link
Collaborator

Closes #15

@bsushmith
Copy link
Collaborator Author

bsushmith commented Apr 5, 2023 •
edited
Loading

The current test cases pass with the addition of this change, though ideally I would expect them not to. Need to check and add test case for this.
was checking incorrect test case. Updated test cases for these changes.

@bsushmith bsushmith marked this pull request as ready for review April 5, 2023 07:02
@coveralls
Copy link

coveralls commented Apr 5, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4616590282

  • 14 of 17 (82.35%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 75.29%
Changes Missing Coverage Covered Lines Changed/Added Lines %
core/provider/service.go 14 17 82.35%
Totals Coverage Status
Change from base Build 4529049075: 0.007%
Covered Lines: 7971
Relevant Lines: 10587
💛 - Coveralls

utsav14nov
utsav14nov reviewed Apr 5, 2023
View reviewed changes
core/provider/service.go Outdated Show resolved Hide resolved
rahmatrhd
rahmatrhd reviewed Apr 5, 2023
View reviewed changes
core/provider/service.go Outdated Show resolved Hide resolved
@bsushmith bsushmith merged commit a5e0740 into main Apr 6, 2023
@bsushmith bsushmith deleted the guardian-15 branch April 6, 2023 11:51
lifosmin pushed a commit to lifosmin/guardian that referenced this pull request Aug 31, 2023
@bsushmith
feat(guardian): add appeal_statuses filter for list approvals API (go…
894c7d7 
…to#16)

- add appeal_statuses filter for list user approvals API
- add appeal_statuses filter for list approvals API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utsav14nov utsav14nov utsav14nov left review comments

@rahmatrhd rahmatrhd rahmatrhd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update provider should also fetch resources for that provider
4 participants
@bsushmith @coveralls @rahmatrhd @utsav14nov