Throw error if XPath expression unspecified

goto100 · Dec 16, 2023 · d5bf3d9 · d5bf3d9
1 parent d1625a4
commit d5bf3d9
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/test.js b/test.js
@@ -1301,6 +1301,18 @@ describe('xpath', () => {
         });
     });
 
+    describe('error handling', () => {
+        it('should reject unspecified expression', () => {
+            for (let expr of [null, undefined, '']) {
+                assert.throws(() => {
+                    xpath.parse(expr);
+                }, {
+                    message: 'XPath expression unspecified'
+                });
+            }
+        });
+    });
+
     describe('Node type tests', () => {
         it('should correctly identify a Node of type Element', () => {
             var doc = parseXml('<book />');

diff --git a/xpath.js b/xpath.js
@@ -1246,6 +1246,10 @@ var xpath = (typeof exports === 'undefined') ? {} : exports;
     XPathParser.ACCEPT = 'a';
 
     XPathParser.prototype.parse = function (s) {
+        if (!s) {
+            throw new Error('XPath expression unspecified');
+        }
+
         var types;
         var values;
         var res = this.tokenize(s);