Fix max call stack issue #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calling the flatten function with a sufficiently large array it will throw: RangeError: Maximum call stack size exceeded This was found when processing very large xml documents and using a // selector in select(). This is due to the maximum argument length limit in javascript/node. Calling apply() with a sufficiently large array will throw a RangeError. See https://bugs.webkit.org/show_bug.cgi?id=80797 for details. Chunk the array into chunks that are smaller than the maximum argument list size using `slice()` and call `concat.apply()` on each chunk so that we never get the range error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request #98 with some modifications.