Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Comma delimited SeriesGroup field in ComicInfo not importing as expected #1122

Closed
5 tasks done
shrublet opened this issue May 31, 2023 · 5 comments
Closed
5 tasks done
Labels
enhancement New feature or request released

Comments

@shrublet
Copy link

Steps to reproduce

  1. Create an archive with the SeriesGroup field in ComicInfo.xml
  2. Import into library with Collections from ComicInfo enabled

Expected behavior

Based on the documentation here for the Anansi Project, I presumed comma-separated values would be converted into discrete collections in Komga.

Actual behavior

Komga imports the collection as a singular entry with a comma in the name instead.

Logs

No response

Komga version

0.165.0

Operating system

Windows 11

Other details

Have additionally tried importing with multiple SeriesGroup fields, but only one is ingested.

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I have checked the FAQ.
  • I have updated the app to the latest version.
  • I will fill out all of the requested information in this form.
@gotson
Copy link
Owner

gotson commented May 31, 2023

From the documentation:

The SeriesGroup element will be used to create a collection with that name, or add the series to an existing collection with that name.

If the SeriesGroup element is set to a different value in each book of the series, then each value of the element will create a collection.

@gotson gotson added question Further information is requested and removed triage labels May 31, 2023
@shrublet
Copy link
Author

Ah, ok I think I understand. Komga doesn't import them individually, but comma-separated values are considered discrete in the ideology of the documentation? If I understand correctly. I wasn't sure as I recall you spearheading creating the documentation for a unified ComicInfo schema. If this is the case, I assume there is no way to have multiple automatically generated collections from multiple SeriesGroup entries? Thanks.

@gotson
Copy link
Owner

gotson commented May 31, 2023

Well ComicInfo is not documented, and the documentation we produced came after the Komga implementation. Changing the behaviour now would introduce a change for existing users, and i am not really sure of what's the usage of that field in the wild.

@shrublet
Copy link
Author

Fair enough. It's not a big deal regardless. I personally just use the field for both original magazine release and franchise, but I'm not sure if these are "intended" uses of these fields. And it's mostly for the fact that Komga automatically organizes these into collections which is convenient. You can go ahead and close this though if Komga is working as intended or this isn't a planned feature.

@gotson gotson added enhancement New feature or request and removed question Further information is requested labels Jun 1, 2023
gotson added a commit to gotson/komga-website that referenced this issue Jun 27, 2023
gotson added a commit that referenced this issue Jun 27, 2023
@gotson gotson closed this as completed in fb13529 Jun 28, 2023
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in v1.0.0 (Release Notes)

gotson added a commit to gotson/komga-website that referenced this issue Jun 28, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request released
Projects
None yet
Development

No branches or pull requests

2 participants