Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nil ref for an invalid node's href's value #147

Closed
cameronmccord2 opened this issue Aug 30, 2021 · 0 comments · Fixed by #148
Closed

Nil ref for an invalid node's href's value #147

cameronmccord2 opened this issue Aug 30, 2021 · 0 comments · Fixed by #148

Comments

@cameronmccord2
Copy link
Contributor

We're getting a NoMethodError when the Favicon scraper is trying to get the href attribute from a node. The node exists but not the href attribute.

The url its failing on is: https://vm.tiktok.com/ZMRkMaRGr/

/gems/link_thumbnailer-3.4.0/lib/link_thumbnailer/scrapers/default/favicon.rb:28 in href
/gems/link_thumbnailer-3.4.0/lib/link_thumbnailer/scrapers/default/favicon.rb:12 in value
/gems/link_thumbnailer-3.4.0/lib/link_thumbnailer/scrapers/base.rb:29 in call
/gems/link_thumbnailer-3.4.0/lib/link_thumbnailer/scraper.rb:39 in block (2 levels) in call
/gems/link_thumbnailer-3.4.0/lib/link_thumbnailer/scraper.rb:38 in each
/gems/link_thumbnailer-3.4.0/lib/link_thumbnailer/scraper.rb:38 in block in call
/gems/link_thumbnailer-3.4.0/lib/link_thumbnailer/scraper.rb:37 in each
/gems/link_thumbnailer-3.4.0/lib/link_thumbnailer/scraper.rb:37 in call
/gems/link_thumbnailer-3.4.0/lib/link_thumbnailer/page.rb:21 in generate
/gems/link_thumbnailer-3.4.0/lib/link_thumbnailer.rb:18 in generate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant