-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to configure the read timeout #53
Conversation
Thanks for the PR, however you cannot change an old configuration attribute like that :) We need to keep the compatibility so that it won't break people's code when upgrading. You should probably add an alias instead. |
0a59d23 |
@@ -1,4 +1,5 @@ | |||
require 'spec_helper' | |||
require 'pry' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, fixed
Allow to configure the read timeout
Hi!
I've added the option to configure the
Net::HTTP::Persistent#read_timeout
, and altered the name of the existing configuration for theNet::HTTP::Persistent#open_timeout
so it's clearer now.