Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeout for unreachable host #19

Closed
tpitale opened this issue Jun 15, 2018 · 3 comments
Closed

Timeout for unreachable host #19

tpitale opened this issue Jun 15, 2018 · 3 comments
Labels
bug

Comments

@tpitale
Copy link
Contributor

tpitale commented Jun 15, 2018 •
edited

coap_client:request(get, "coap://somehost/api")

This never times out if the host is unreachable. I see that coap_transport has mention of ACK_TIMEOUT so I'm not sure why this won't error.

Any help/ideas would be much appreciated, thanks!
@gotthardp gotthardp added the bug label Jun 22, 2018
@gotthardp
Copy link
Owner

Hi. There appears to be no timeout in the coap_client. That is of course wrong.

gotthardp added a commit that referenced this issue Jun 23, 2018
@gotthardp
Issue #19: Add timeout for client
bd24de7
@gotthardp
Copy link
Owner

Hello again. I just made fix. Default timeout is now 30s and it can be modified by a new coap_client:request parameter.

@tpitale
Copy link
Contributor Author

tpitale commented Jun 24, 2018

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tpitale @gotthardp