Skip to content
This repository has been archived by the owner on Mar 6, 2018. It is now read-only.

Timeout not working correctly #13

Closed
ivankosdy opened this issue Jul 16, 2012 · 3 comments
Closed

Timeout not working correctly #13

ivankosdy opened this issue Jul 16, 2012 · 3 comments

Comments

@ivankosdy
Copy link

Why do you call cleanup() here:
https://github.com/Gottox/socket.io-java-client/blob/master/src/io/socket/IOConnection.java#L151 ?

Calling error() after cleanup() is useless, isn't it?

I guess there should be called only error(...) method.

@Gottox
Copy link
Owner

Gottox commented Jul 16, 2012

Thanks, fixed this.

But multiple calls of cleanup shouldn't be a problem.

@Gottox Gottox closed this as completed Jul 16, 2012
@ivankosdy
Copy link
Author

Sure, but onError event wasn't called in error() method because of previously cleared sockets in cleanup().

edit: btw thanks for such a quick response :)

@Gottox
Copy link
Owner

Gottox commented Jul 17, 2012

Oh, you're right, thanks :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants