Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

istanbul version 0.3.17 breaks CI, because console.error() #606

Closed
viktordavidovich opened this issue Apr 26, 2016 · 2 comments
Closed

istanbul version 0.3.17 breaks CI, because console.error() #606

viktordavidovich opened this issue Apr 26, 2016 · 2 comments

Comments

@viktordavidovich
Copy link

Istanbul version 0.3.17 breaks CI, namely TFS build, because inside lib/collector.js
line 164 we have next code:

            if (cache.hasMappings()) {
                console.error('Post-processing using source maps');
                t = cache.transformer();
            }

Build breaks, because error exists. This is absolutely wrong, because post-processing using source maps is not error.
I've investigated, that inside newest version of Istanbul - everything is fine and console.log, console.error are not existing already there.

Just note, DON"T PUSH DEV TOOLS TO THE PRODUCTION CODE!
You can break somebodies build 👍

@fizker
Copy link

fizker commented Apr 26, 2016

I would rather say that your CI setup is incorrect, if data on stderr breaks it. You should listen to exit codes instead.

Many *nix utilities (which is the inspiration for a lot of node tools) are using stderr as progress updates and the like. Take curl for example, where the data you are downloading goes to stdout and the progress updates go to stderr.

@mpalomas
Copy link

mpalomas commented May 3, 2016

Unfortunately some (bad?) CI such as TFS have no setting for this: it's just the default behavior.

The workaround I use (for other tool such as Git) is to redirect stderr to stdout hoping it won't break anything. And soon a better workaround: just don't use TFS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants