Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Istanbul Clover report output #145

Merged
merged 4 commits into from Mar 5, 2014
Merged

Conversation

bixdeng
Copy link

@bixdeng bixdeng commented Jan 28, 2014

For this pull request, we have implemented a Clover reporter that is compatible with Atlassian Bamboo Continuous Integration server. Bamboo CI only accepts NCover or Clover format metrics, and this posed as an issue in our workflow. Others have also encountered the same issue documented here:

https://groups.google.com/forum/#!topic/karma-users/yww1YRdMi_s

I used a sample clover.xml output file as reference and implemented the clover.js file, which is a cloned and modified version of the cobertura.js file. The output format is tailored for Bamboo to capture all the necessary metrics for proper code coverage integration. It has solved an issue in our workflow and I believe this will be beneficial to anyone else who uses Karma and Bamboo CI.

I did not get a chance to create unit tests for our changes, as I ran into trouble running ‘npm test’ in the root directory and did not succeed. For now I just want to share this implementation to the public, but I would be glad to cooperate to get that done.

@gotwarlost
Copy link
Owner

Could you please add a test case even if it is a very basic one? Also merge the commit c469986 into your source tree so that the tests work correctly.

@mpderbec
Copy link

mpderbec commented Feb 1, 2014

Unit test has been added, modeled after the Cobertura test. Should be ready for merge now.

gotwarlost added a commit that referenced this pull request Mar 5, 2014
Istanbul Clover report output
@gotwarlost gotwarlost merged commit f2c84f9 into gotwarlost:master Mar 5, 2014
@eggers
Copy link

eggers commented Mar 12, 2014

Awesome, thanks for this. If this is merged into master, you should probably add clover to report types in the readme.

@yagoferrer
Copy link

Tears of joy! Thank you so much!

@chr0n1x
Copy link

chr0n1x commented Feb 9, 2015

@gotwarlost I just found this. Thank you so much!

@kagant15
Copy link

I see that ncloc (Non-comment lines of code) is displaying the exact same value as loc (Lines of code). It would be great to know how many lines of code are not comments. Is there a plan to add this feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants