Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swap fileset for glob, Fixes #638 #673

Merged
merged 1 commit into from Aug 21, 2016

Conversation

popomore
Copy link
Contributor

@popomore popomore commented Jul 28, 2016

I fixed the testcase picking from #648 and delete glob from devDependencies.

It can be closed once #648 have been merged.

@coveralls
Copy link

coveralls commented Jul 28, 2016

Coverage Status

Coverage remained the same at 97.523% when pulling 92f458b on popomore:swap-fileset-for-glob into fef889b on gotwarlost:master.

@popomore
Copy link
Contributor Author

#638

@popomore
Copy link
Contributor Author

@mklabs @gotwarlost any suggestion?

@popomore
Copy link
Contributor Author

ping @mklabs @gotwarlost

@mklabs
Copy link

mklabs commented Jul 29, 2016

Hi @popomore I really don't know what to do or to say. I personally think this is a good move and a really good PR. 👍

@popomore
Copy link
Contributor Author

now istanbul will break synk causing minimatch

@popomore
Copy link
Contributor Author

popomore commented Aug 3, 2016

ping @gotwarlost

@popomore
Copy link
Contributor Author

popomore commented Aug 3, 2016

@gotwarlost do you recommend to use nyc instead of istanbul?

@popomore
Copy link
Contributor Author

ping @gotwarlost

@maxkoryukov
Copy link

I have tried to attach all related issues and pull requests

@maxkoryukov
Copy link

@gotwarlost, it is really useful PR, could you merge it? This PR solves all problems with fileset and there are no failures (mentioned here)

Also:

@popomore , if you will mention this list of issues in one of your commits' messages, then them all will become closed on merging

- Close gotwarlost#648 (ORIGINAL PR with similar purpose)
- Close gotwarlost#658 (PR with similar purpose)
- Fix gotwarlost#638
- Fix gotwarlost#678
- Fix gotwarlost#653
@popomore
Copy link
Contributor Author

Thx @maxkoryukov, I have pushed with message body.

@popomore
Copy link
Contributor Author

ping @gotwarlost

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.523% when pulling 58f4c90 on popomore:swap-fileset-for-glob into fef889b on gotwarlost:master.

@maxkoryukov
Copy link

waiting for @gotwarlost

@gotwarlost
Copy link
Owner

Thanks for the PR. Sorry for the delay in merging this. Have been busy with other things...

@gotwarlost gotwarlost merged commit da79378 into gotwarlost:master Aug 21, 2016
@gotwarlost
Copy link
Owner

available in v0.4.5

@maxkoryukov
Copy link

Wooohooo)) You did it! Thanks!

@maxkoryukov
Copy link

@popomore , @graingert thank you, for the fix;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants