Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implementing missing ff_eventcodes #47

Open
ciscoyo opened this issue Nov 29, 2023 · 5 comments
Open

implementing missing ff_eventcodes #47

ciscoyo opened this issue Nov 29, 2023 · 5 comments

Comments

@ciscoyo
Copy link

ciscoyo commented Nov 29, 2023

General
Support for a bunch of effects, mostly copy-pasted from new-lg4ff. Note: only tested with CSL Elite Wheelbase. Currently not supported effects: FF_FRICTION, FF_INERTIA

and i thought, its only me, coz i do not have the newest firmware..
ye, im stupid.. i should have just read the fukin descrition.. xD
(i deleted the other post about it ^^)

so again im offering my help/input/tests with this whenever! since its the most important feedback u want to have as a driver ^^ (and tbh, im still completely shocked that no one has ever even mentioned it before Oo). i mean, driving with sensing the current grip is way easier and faster than just trail and error and try memorise it (especially in f1 23, where u dont even have the audio input for it). than u r able to handle the over-understeer way better. and its creates a way more realistic immersion ofc ^^

i saw that @dtran11 did something similar here as well. https://github.com/gotzl/hid-fanatecff/issues/45#issuecomment-1787556135
it might help a bit. actually, ive heard that AI is really strong in these kind of thinks btw ^^

@gotzl i can close the other thread, no? im asking, coz i dont know the behavior here on github. and speaking about behavior, is this even the right tap or should i created it at pull requests?

@gotzl
Copy link
Owner

gotzl commented Dec 4, 2023

so again im offering my help/input/tests with this whenever! since its the most important feedback u want to have as a driver ^^ (and tbh, im still completely shocked that no one has ever even mentioned it before Oo). i mean, driving with sensing the current grip is way easier and faster than just trail and error and try memorise it (especially in f1 23, where u dont even have the audio input for it). than u r able to handle the over-understeer way better. and its creates a way more realistic immersion ofc ^^

Why do you think this is needed by F1 23? Did you by any chance compare to the effects you get on windows? The thing is that most games actually don't use these effect types (ff_friction/ff_inertia/....). They often only use ff_constant to create all the effects (ACC for instance is such a game) and I think, rFactor only uses ff_sine. I'm not sure about F1 23, and I will check if it actually makes use of ff_friction.

is this even the right tap or should i created it at pull requests?

Yes, this is the right tab. Pull requests are for integrating code from a fork. So, if you'd implemented it, and you would want to have this implementation pulled into my repo.

i can close the other thread, no?

Which other thread? Generally, if you opened it and you're happy with the outcome, you can just close it (maybe add a comment why you believe closing was a good action).

gotzl pushed a commit that referenced this issue Dec 9, 2023
@gotzl
Copy link
Owner

gotzl commented Dec 9, 2023

So, after some testing, I found that F1 23 uses FF_DAMPER and FF_CONSTANT only.
However, EA Sports WRC does use FF_FRICTION, and possibly Dirt Rally 2 as well. So, I've experimentally enabled it for further testing, but it doesn't feel quit alright just yet...

@dtran11
Copy link

dtran11 commented Dec 13, 2023

I just tried out FF_FRICTION, it seems to feel just like FF_DAMPER to me.

@gotzl
Copy link
Owner

gotzl commented Dec 13, 2023

@dtran11 yep, the command send to the device is the same for FF_FRICTION / FF_INERTIA / FF_DAMPER, at least that's what I saw from WheelCheck. I thought, maybe games use different parameters to achieve the wished effect?
But yea, I'm a bit puzzled with this, too... I'm open for ideas ;)

@ciscoyo
Copy link
Author

ciscoyo commented Dec 20, 2023

i will update/edit this later for more!

but for now, i only interested in how do u guys know that? how can i test this by myself?

quick edit:

  • Edit the title. but from what im capable of reading code, there is nothing missing anymore, no? @gotzl
    this means i can close this and than we only need to focus fixing the ff_eventcodes codelines, coz there r not fully functional yet (s.b.)! but its also possible, thats only related due the missing prefixes! i l figured that out, when i tried to help a linux thrustmaster user. the ffb output actually CAN change with different prefixes/win drivers!
  • raceroom uses ff_sine only for there ffb output. almost 100% confirmed
    the ffb output is the same as in windows pretty sure. its feels great and how it should be

So, after some testing, I found that F1 23 uses FF_DAMPER and FF_CONSTANT only.

  • i also can almost 100% confirm, that this game has actually good tire friction output (like feel the grip through vibrations) as well. and for me, every car is completely dead, no ffb! so like mentioned above, there must be something wrong/missing/whatever within the code, or missing prefix/win driver.

@ciscoyo ciscoyo changed the title implementing ff_friction implementing missing ff_eventcodes Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants