Refactor CLI setup #194
Merged
Refactor CLI setup #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-286
to
-292
| @click.option( | ||
| "--http_extra_headers", | ||
| cls=OptionAcceptableFromConfig, | ||
| type=(str, str), | ||
| multiple=True, | ||
| help="Additional HTTP request header to be sent to Metabase.", | ||
| ) |
There was a problem hiding this comment.
Hi, I see that this part has been removed from the new version 1.0.0, is it expected?
There was a problem hiding this comment.
Still available in the programmatic API. I couldn't get the dictionary type to work via CLI flag, were you using it via config YAML file?
There was a problem hiding this comment.
Released in v1.0.1, you can now use:
dbt-metabase [COMMAND]
--http-header x-some-header-1 some-value-1
--http-header x-some-header-2 some-value-2or via YAML config:
config:
http_headers:
- [x-some-header-1, some-value-1]
- [x-some-header-2, some-value-2]
|
That was fast, thank you 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--dbt_databasebecomes--dbt-database)--dbt-includes model1 model2becomes--dbt-includes model1,model2)METABASE_instead ofMB_dbt-metabase config)--dbt-pathis now--dbt-project-path)dbt-metabase --config-file path/to/config.yml models)scripttoentry_pointsin setup.py for better cross-platform support