fix exposures crashing with referencing questions with multiple variables #226
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Running
dbt-metabase exposures
produces faultyexposures.json
if the referenced Metabase questions contain multiple variables in one query.To reproduce
The problem is due to the greedy nature of the
.*
regex pattern that will catch multiple sets of double braces if they exist within the same line.Example query:
Solution
Make the regex less greedy to match as little text as possible.