[91] - switching the patterns in the MediaInternetGovCmsCkanHandler->… #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge latest develop branch for 1.1 release.
7.2 Release for govCMS CKAN. - Fixes govCMS#74 Adds support for non-standard CKAN ports - Fixes govCMS#76 for formatting improvements - Adds defensive coding practises to prevent errors - Updates max lenght on URL field - Adds record limit configuration by variables - Adds cache control per graph - Addresses IE11 download issue
…parse function to use baseUrl instead of baseHost
|
Requested reviews from some of the primary contributors. |
| '@' . $this->baseHost . '/dataset/([^"\&\? ]+)/resource/([^"\&\? ]+)/download/(?:[^"\&\? ]+)@i', | ||
| '@' . $this->baseHost . '/dataset/([^"\&\? ]+)/resource/([^"\&\? ]+)@i', | ||
| '@' . $this->baseUrl . '/dataset/([^"\&\? ]+)/resource/([^"\&\? ]+)/download/(?:[^"\&\? ]+)@i', | ||
| '@' . $this->baseUrl . '/dataset/([^"\&\? ]+)/resource/([^"\&\? ]+)@i', |
There was a problem hiding this comment.
That one was changed to support ckan endpoints using different ports, could we instead change where baseUrl is set to also include the path if it exists?
…dded to the baseURL will still work as requested.
|
@seanhamlin , @jeremy-doghouse , I've made a small update to include the baseHost and a basePath. |
|
Approved pending changing the base branch to develop. @SRowlands or @steveworley can you please have a look at this too. |
steveworley
approved these changes
May 9, 2017
|
@tobybellwood @steveworley @SRowlands , any idea on a timeline for getting this into govCMS? |
stooit
approved these changes
Jun 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#91