Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testing. #2

Merged
merged 4 commits into from
Apr 15, 2020
Merged

Add testing. #2

merged 4 commits into from
Apr 15, 2020

Conversation

simesy
Copy link
Contributor

@simesy simesy commented Oct 18, 2019

No description provided.

@simesy simesy requested review from tobybellwood and removed request for tobybellwood October 18, 2019 04:55
@simesy simesy changed the base branch from master to develop October 19, 2019 23:55
Copy link

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

- image: quay.io/govcms/govcms-ci
steps:
- checkout
- run: composer validate --strict || true

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason why it is ||true?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably just informative. But I think it has come from another test i copied.

composer --working-dir=/app update
composer --working-dir=/app require govcms/require-dev:dev-latest-package-"${CIRCLE_SHA1}" --ignore-platform-reqs
- run:
name: Test settings via drush

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

misleading name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that got copied from another test.

.circleci/config.yml Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
@stooit stooit merged commit 1b17e1e into govCMS:develop Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants