Skip to content
This repository has been archived by the owner on Aug 26, 2021. It is now read-only.

Odd menu item overlap #573

Closed
rhubarbselleven opened this issue Dec 12, 2018 · 5 comments
Closed

Odd menu item overlap #573

rhubarbselleven opened this issue Dec 12, 2018 · 5 comments
Labels
enhancement New feature or request. submitted by user Issues on behalf of users.

Comments

@rhubarbselleven
Copy link

Example overlap

Using: Chrome Version 71.0.3578.80 (Official Build) (64-bit)

@alex-page
Copy link
Contributor

alex-page commented Dec 12, 2018

@rhubarbselleven thanks for sharing the issue. From what I can tell it occurs when a user hovers on a menu item then focuses on the previous item.

This is a bit of an odd pattern to fix as it is quite rare that the user will be using the mouse and keyboard at the same time. That being said I am happy to investigate it and see if there are any easy resolutions. I'm not to keen on adding a z-index on the current focused item to bring it above other items.

@alex-page alex-page transferred this issue from govau/design-system-starter Dec 12, 2018
@alex-page alex-page added the enhancement New feature or request. label Dec 12, 2018
@alex-page alex-page added this to 🌱 Product Backlog in Design System Dec 12, 2018
@rhubarbselleven
Copy link
Author

Hey @alex-page, It’s not keyboard and mouse but odd active and hover states when the list items are anchors with no real href.

If they had a real location, we wouldn’t see this state

@alex-page
Copy link
Contributor

Thanks for the information. We will take a look in the next sprint!

@alex-page alex-page moved this from 🌱 Product Backlog to ✏️ Sprint backlog in Design System Jan 3, 2019
@alex-page
Copy link
Contributor

alex-page commented Jan 4, 2019

@rhubarbselleven I am investigating this issue. I am using the https://govau.github.io/design-system-starter/form/ website as it mimics the markup you have described above.

I am a bit confused on how to repeat the issue. How I am trying:

  • The "Form" menu item is active
  • I move focus to the "Simple terms" menu item
  • I click "Distinct from eachother" and the focus moves to that item?

  • The "Form" menu item is active
  • I click "Distinct from eachother"
  • I move focus to the "Simple terms" menu item, the hover colour is now removed from "Distinct from eachother"

@alex-page alex-page added the submitted by user Issues on behalf of users. label Jan 4, 2019
@alex-page
Copy link
Contributor

@rhubarbselleven I am going to close this issue as I can't replicate it. If you can provide steps happy to re open the issue.

Design System automation moved this from ✏️ Sprint backlog to ✨ Done Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request. submitted by user Issues on behalf of users.
Projects
Design System
  
✨ Done
Development

No branches or pull requests

2 participants