-
Notifications
You must be signed in to change notification settings - Fork 76
As a site user I want the social media links to be accessible so that I can read them with a screenreader #120
Comments
Comment from @fribibb: GOVCMS-121-images.zip |
Comment from @fribibb: Alternatively we could use font icons such as font awesome or http://perfecticons.com/ |
@fribibb can you please provide images for email, flickr and vimeo and all of the images in svg format please. |
ok, current status on this is @ruwanl has implemented ~85% into the custom module, using the perfecticons font-icons method + updating markup to be UL/LI rather than DIVs. But we discovered that there is a contrib module within govCMS too - both modules are used on multiple live sites currently too. |
Have gone through the current sites and it seems only one site is using the contrib module. Some sites have implemented the sharing via the theme and the rest either do not have social sharing or are using the custom govCMS module. |
So, what is the way forward here? We'll have to work with the current site using the contrib module to change what they're doing. Can we make this change in the next release, move the site using it to the new sharing icon method, and then remove the module in the release afterwards? |
Two changes are needed:
Markup currently has two separate tags per social link. this would make a screen reader read out "Facebook. Facebook. Twitter. Twitter." etc.
This needs to be made to use one tag that wraps both, or even remove the text completely as there is a title and alt text on the image, which is sufficient.
Facebook, Twitter and YouTube's logos are all not in compliance with their current branding guidelines. See attached for updated images, note this are in higher resolution than the current so we can provide support for retina devices - ideally by using the "srcset" attribute on the tag.
The text was updated successfully, but these errors were encountered: