Skip to content
This repository has been archived by the owner on Dec 6, 2022. It is now read-only.

As a site user I want the social media links to be accessible so that I can read them with a screenreader #120

Open
aleayr opened this issue Dec 7, 2015 · 6 comments
Milestone

Comments

@aleayr
Copy link
Contributor

aleayr commented Dec 7, 2015

Two changes are needed:

  1. Markup currently has two separate tags per social link. this would make a screen reader read out "Facebook. Facebook. Twitter. Twitter." etc.
    This needs to be made to use one tag that wraps both, or even remove the text completely as there is a title and alt text on the image, which is sufficient.

  2. Facebook, Twitter and YouTube's logos are all not in compliance with their current branding guidelines. See attached for updated images, note this are in higher resolution than the current so we can provide support for retina devices - ideally by using the "srcset" attribute on the tag.

@aleayr aleayr added the imported label Dec 7, 2015
@aleayr aleayr added this to the beta7 milestone Dec 7, 2015
@aleayr
Copy link
Contributor Author

aleayr commented Dec 7, 2015

Comment from @fribibb:

GOVCMS-121-images.zip
See attached zip file for optimised images to be used.

@aleayr
Copy link
Contributor Author

aleayr commented Dec 7, 2015

Comment from @fribibb:

Alternatively we could use font icons such as font awesome or http://perfecticons.com/

@fiasco fiasco added the ux label Dec 8, 2015
@ruwanl
Copy link
Contributor

ruwanl commented Dec 9, 2015

@fribibb can you please provide images for email, flickr and vimeo and all of the images in svg format please.

@fribibb
Copy link
Contributor

fribibb commented Dec 11, 2015

ok, current status on this is @ruwanl has implemented ~85% into the custom module, using the perfecticons font-icons method + updating markup to be UL/LI rather than DIVs. But we discovered that there is a contrib module within govCMS too - both modules are used on multiple live sites currently too.
So we'll discuss Monday to figure out whether to continue with custom or attempt to contribute back into the public module...

@ruwanl
Copy link
Contributor

ruwanl commented Dec 17, 2015

Have gone through the current sites and it seems only one site is using the contrib module. Some sites have implemented the sharing via the theme and the rest either do not have social sharing or are using the custom govCMS module.

@aleayr
Copy link
Contributor Author

aleayr commented Jan 22, 2016

@ruwanl @fribibb

So, what is the way forward here? We'll have to work with the current site using the contrib module to change what they're doing.

Can we make this change in the next release, move the site using it to the new sharing icon method, and then remove the module in the release afterwards?

@fiasco fiasco removed this from the beta7 milestone Apr 1, 2016
@aleayr aleayr added this to the Future milestone Jul 27, 2016
@fribibb fribibb added the ready label Sep 6, 2016
@fribibb fribibb self-assigned this Sep 6, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants